From: Mukund Sivaraman <muks@isc.org>
Date: Tue, 12 Jun 2012 22:35:53 +0000 (+0530)
Subject: [2036] Return non-zero exit status when valgrind finds an issue
X-Git-Tag: trac2351_base~226^2~42^2~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3317bd6b1575ce0114a6797c5eb727a0978770de;p=thirdparty%2Fkea.git

[2036] Return non-zero exit status when valgrind finds an issue

This should work fine with make check, so long as we have all issues
fixed or covered by suppressions. In this case, whenever a new issue
is introduced, make check would fail.
---

diff --git a/configure.ac b/configure.ac
index 9e87477f1c..07c30dc6d6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -991,7 +991,7 @@ AC_ARG_ENABLE(valgrind, [AC_HELP_STRING([--enable-valgrind],
 AM_CONDITIONAL(ENABLE_VALGRIND, test "x$enable_valgrind" != "xno")
 
 if test "x$VALGRIND" != "xno" -a "x$enable_valgrind" != "xno"; then
-   VALGRIND_COMMAND="$VALGRIND -q --gen-suppressions=all --suppressions=\$(top_srcdir)/src/valgrind-suppressions --suppressions=\$(top_srcdir)/src/valgrind-suppressions.revisit --num-callers=24 --leak-check=full --fullpath-after="
+   VALGRIND_COMMAND="$VALGRIND -q --error-exitcode=1 --gen-suppressions=all --suppressions=\$(top_srcdir)/src/valgrind-suppressions --suppressions=\$(top_srcdir)/src/valgrind-suppressions.revisit --num-callers=24 --leak-check=full --fullpath-after="
 fi
 AC_SUBST(VALGRIND_COMMAND)