From: Shrikanth Hegde Date: Wed, 3 Jun 2026 13:10:54 +0000 (+0530) Subject: powerpc/entry: Disable interrupts before irqentry_exit X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=334f3f6d7a1660fd65597bad9960bfa33a716d35;p=thirdparty%2Fkernel%2Flinux.git powerpc/entry: Disable interrupts before irqentry_exit Venkat reported a panic on powerpc-next tree where GENERIC_ENTRY has been enabled. kernel BUG at kernel/sched/core.c:7512! NIP preempt_schedule_irq+0x44/0x118 LR dynamic_irqentry_exit_cond_resched+0x40/0x1a4 Call Trace: dynamic_irqentry_exit_cond_resched+0x40/0x1a4 do_page_fault+0xc0/0x104 data_access_common_virt+0x210/0x220 This happens since __do_page_fault ends up enabling the interrupts and it could take significant time such that need_resched could be set. This leads to schedule call in irqentry_exit leading to the bug. There are many such irq handlers which enables the interrupts. Fix it by disabling the irq before calling irqentry_exit. The same pattern exists today in interrupt_exit_kernel_prepare. Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") Reported-by: Venkat Rao Bagalkote Closes: https://lore.kernel.org/all/7904105b-9dfa-4efd-a5ef-bc0276ed255d@linux.ibm.com/ Signed-off-by: Shrikanth Hegde Tested-by: Venkat Rao Bagalkote Reviewed-by: Mukesh Kumar Chaurasiya (IBM) Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/20260603131054.216235-1-sshegde@linux.ibm.com --- diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h index de5601282755..fc636c42e89a 100644 --- a/arch/powerpc/include/asm/entry-common.h +++ b/arch/powerpc/include/asm/entry-common.h @@ -260,9 +260,10 @@ static inline void arch_interrupt_exit_prepare(struct pt_regs *regs) * AMR can only have been unlocked if we interrupted the kernel. */ kuap_assert_locked(); - - local_irq_disable(); } + + /* irqentry_exit expects to be called with interrupts disabled */ + local_irq_disable(); } static inline void arch_interrupt_async_enter_prepare(struct pt_regs *regs)