From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Date: Sun, 4 May 2014 10:19:33 +0000 (+0200)
Subject: Better check for null signature method.
X-Git-Tag: gnutls_3_3_2~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=33517328e4fa7a90baddebca7caf672093ea9b44;p=thirdparty%2Fgnutls.git

Better check for null signature method.

Issue identified using valgrind and the Codenomicon TLS test suite.
---

diff --git a/lib/algorithms/sign.c b/lib/algorithms/sign.c
index 5da5bf3668..e69cd0c531 100644
--- a/lib/algorithms/sign.c
+++ b/lib/algorithms/sign.c
@@ -299,7 +299,8 @@ _gnutls_tls_aid_to_sign(const sign_algorithm_st * aid)
 {
 	gnutls_sign_algorithm_t ret = GNUTLS_SIGN_UNKNOWN;
 
-	if (memcmp(aid, &unknown_tls_aid, sizeof(*aid)) == 0)
+	if (aid->hash_algorithm == unknown_tls_aid.hash_algorithm &&
+		aid->sign_algorithm == unknown_tls_aid.sign_algorithm)
 		return ret;
 
 	GNUTLS_SIGN_LOOP(