From: Alexander Færøy <ahf@torproject.org>
Date: Sat, 23 Jun 2018 09:28:00 +0000 (+0200)
Subject: Fix memory leak in disk_state_parse_commits().
X-Git-Tag: tor-0.2.9.16~9^2^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3395de51a01aa5519c52404ed2bb9c8cda3571c9;p=thirdparty%2Ftor.git

Fix memory leak in disk_state_parse_commits().

This patch fixes a memory leak in disk_state_parse_commits() where if
commit is NULL, we continue the internal loop, but without ever freeing
the args variable.

See: Coverity CID 1437441.
---

diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c
index 87db9031ee..8438d46404 100644
--- a/src/or/shared_random_state.c
+++ b/src/or/shared_random_state.c
@@ -409,6 +409,7 @@ disk_state_parse_commits(sr_state_t *state,
     if (commit == NULL) {
       /* Ignore badly formed commit. It could also be a authority
        * fingerprint that we don't know about so it shouldn't be used. */
+      smartlist_free(args);
       continue;
     }
     /* We consider parseable commit from our disk state to be valid because