From: Shawn Routhier <sar@isc.org>
Date: Fri, 2 Oct 2015 02:33:54 +0000 (-0700)
Subject: [trac3576] Updates per review comments
X-Git-Tag: trac3874_base~40^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=33f0882b59b0a9e62ace24fd8b62fb2ebdc90b1f;p=thirdparty%2Fkea.git

[trac3576] Updates per review comments

Typo level changes per review comments.
---

diff --git a/ChangeLog b/ChangeLog
index ff2947fd3a..dd2546fc47 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+101x.   [func]		sar
+	Added support for several options for use by PXE.
+	From RFC4578 (for DHCPv4) these are: 93 - client-system,
+	94 - client-ndi, 97 - uuid-guid.
+	From RFC5970 (for  DHCPv6) these are: 59 - bootfile-url,
+	60 - bootfile-param, 61 - client-arch-type, 62 - nii.
+	(trac #3576, git <TBD>)
+
 1011.	[func]		fdupont
 	Added definitions and tests for the options from secure DHCPv6.
 	This protocol is still experimental. The option and other protocol
diff --git a/src/lib/dhcp/option_opaque_data_tuples.h b/src/lib/dhcp/option_opaque_data_tuples.h
index 9e656caa90..d9507c875b 100644
--- a/src/lib/dhcp/option_opaque_data_tuples.h
+++ b/src/lib/dhcp/option_opaque_data_tuples.h
@@ -107,9 +107,9 @@ public:
 
     /// @brief Returns opaque data tuple at the specified position.
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
 
@@ -123,7 +123,7 @@ public:
         return (tuples_);
     }
 
-    /// @brief Checks if the object  holds the opaque data tuple with the
+    /// @brief Checks if the object holds the opaque data tuple with the
     /// specified string.
     ///
     /// @param tuple_str String representation of the tuple being searched.
diff --git a/src/lib/dhcp/option_vendor_class.h b/src/lib/dhcp/option_vendor_class.h
index 83a3831bd6..51d410f75d 100644
--- a/src/lib/dhcp/option_vendor_class.h
+++ b/src/lib/dhcp/option_vendor_class.h
@@ -119,9 +119,9 @@ public:
 
     /// @brief Returns opaque data tuple at the specified position.
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
 
diff --git a/src/lib/dhcp/tests/libdhcp++_unittest.cc b/src/lib/dhcp/tests/libdhcp++_unittest.cc
index 1e5d6a8549..fef4b5d092 100644
--- a/src/lib/dhcp/tests/libdhcp++_unittest.cc
+++ b/src/lib/dhcp/tests/libdhcp++_unittest.cc
@@ -1179,7 +1179,7 @@ TEST_F(LibDhcpTest, stdOptionDefs6) {
                                     typeid(Option6AddrLst));
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_URL, begin, end,
-				    typeid(OptionString));
+                                    typeid(OptionString));
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_PARAM, bparam_buf.begin(),
                                     bparam_buf.end(),
diff --git a/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc b/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
index 7dbd905710..fa3958071c 100644
--- a/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
+++ b/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
@@ -215,7 +215,7 @@ TEST(OptionOpaqueDataTuples, unpack6NoTuple) {
     // Prepare data to decode.
     const uint8_t buf_data[] = {
     };
-    OptionBuffer buf(buf_data,buf_data + sizeof(buf_data));
+    OptionBuffer buf(buf_data, buf_data + sizeof(buf_data));
 
     OptionOpaqueDataTuplesPtr data_tuple;
     ASSERT_NO_THROW(