From: Dave Miller <justdave@bugzilla.org>
Date: Sun, 28 Apr 2024 04:31:36 +0000 (-0400)
Subject: (no bug) Backout PR #60 - new feature not valid for stable branch (#164)
X-Git-Tag: bugzilla-5.0.4.1~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=340c5f43bf00ad5723f8c91ee38c7893714c54ac;p=thirdparty%2Fbugzilla.git

(no bug) Backout PR #60 - new feature not valid for stable branch (#164)

This was accidentally included in the 5.0.4 branch, which should have branched just before this commit. Everything else after it before we did end up branching would have been cherry-picked anyway.
---

diff --git a/Bugzilla/Hook.pm b/Bugzilla/Hook.pm
index d8ae674636..d6ba5e1d0e 100644
--- a/Bugzilla/Hook.pm
+++ b/Bugzilla/Hook.pm
@@ -1479,21 +1479,6 @@ look at the code for C<create> in L<Bugzilla::Template>.)
 
 =back
 
-=head2 template_after_create
-
-This hook allows you to manipulate the Template object before it is used.
-You can use this to define new vmethods or filters in extensions.
-
-Params:
-
-=over
-
-=item C<template>
-
-This is the L<Bugzilla::Template> object.
-
-=back
-
 =head2 template_before_process
 
 This hook is called any time Bugzilla processes a template file, including
diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm
index 7294e27c19..decffe1e8d 100644
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -1186,7 +1186,6 @@ sub create {
     Bugzilla::Hook::process('template_before_create', { config => $config });
     my $template = $class->new($config) 
         || die("Template creation failed: " . $class->error());
-    Bugzilla::Hook::process('template_after_create', { template => $template });
 
     # Pass on our current language to any template hooks or inner templates
     # called by this Template object.
diff --git a/extensions/Example/Extension.pm b/extensions/Example/Extension.pm
index c4fabe656b..dbc84df721 100644
--- a/extensions/Example/Extension.pm
+++ b/extensions/Example/Extension.pm
@@ -920,19 +920,6 @@ sub template_before_create {
     $config->{VARIABLES}->{example_global_variable} = sub { return 'value' };
 }
 
-sub template_after_create {
-    my ( $self, $args ) = @_;
-    my $context = $args->{template}->context;
-
-    # define a pluck method on template toolkit lists.
-    $context->define_vmethod(
-        list => pluck => sub {
-            my ( $list, $field ) = @_;
-            return [ map { $_->$field } @$list ];
-        }
-    );
-}
-
 sub template_before_process {
     my ($self, $args) = @_;