From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 23 Nov 2014 16:05:18 +0000 (+0100)
Subject: video: uvesafb: Deletion of an unnecessary check before the function call "platform_d... 
X-Git-Tag: v3.19-rc1~121^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=34685627288baa370a6102ce58d47266d24050fd;p=thirdparty%2Fkernel%2Fstable.git

video: uvesafb: Deletion of an unnecessary check before the function call "platform_device_put"

The platform_device_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index f718627b368f2..d32d1c4d1b99f 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1922,8 +1922,7 @@ static int uvesafb_init(void)
 			err = -ENOMEM;
 
 		if (err) {
-			if (uvesafb_device)
-				platform_device_put(uvesafb_device);
+			platform_device_put(uvesafb_device);
 			platform_driver_unregister(&uvesafb_driver);
 			cn_del_callback(&uvesafb_cn_id);
 			return err;