From: Thorsten Lünborg <t.luenborg@googlemail.com>
Date: Fri, 27 Nov 2020 15:24:31 +0000 (+0100)
Subject: fix(reactivity): ensure  readonly on plain arrays doesn't track array methods. (... 
X-Git-Tag: v3.0.4~45
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=34703082fd5afacee774ee92c11753119032ed1a;p=thirdparty%2Fvuejs%2Fcore.git

fix(reactivity): ensure  readonly on plain arrays doesn't track array methods. (#2506)

fix #2493
---

diff --git a/packages/reactivity/__tests__/readonly.spec.ts b/packages/reactivity/__tests__/readonly.spec.ts
index ff73e43bcf..b9edb440fb 100644
--- a/packages/reactivity/__tests__/readonly.spec.ts
+++ b/packages/reactivity/__tests__/readonly.spec.ts
@@ -375,6 +375,16 @@ describe('reactivity/readonly', () => {
     expect(dummy).toBe(1)
   })
 
+  test('readonly array should not track', () => {
+    const arr = [1]
+    const roArr = readonly(arr)
+
+    const eff = effect(() => {
+      roArr.includes(2)
+    })
+    expect(eff.deps.length).toBe(0)
+  })
+
   test('readonly should track and trigger if wrapping reactive original (collection)', () => {
     const a = reactive(new Map())
     const b = readonly(a)
diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts
index a246b6f319..5f57a3c9f9 100644
--- a/packages/reactivity/src/baseHandlers.ts
+++ b/packages/reactivity/src/baseHandlers.ts
@@ -83,7 +83,8 @@ function createGetter(isReadonly = false, shallow = false) {
     }
 
     const targetIsArray = isArray(target)
-    if (targetIsArray && hasOwn(arrayInstrumentations, key)) {
+
+    if (!isReadonly && targetIsArray && hasOwn(arrayInstrumentations, key)) {
       return Reflect.get(arrayInstrumentations, key, receiver)
     }