From: robertc <>
Date: Wed, 15 Oct 2003 18:03:08 +0000 (+0000)
Subject: don't assert when closing ntlm connections as the user may be locked for logging... 
X-Git-Tag: SQUID_3_0_PRE4~1189
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3587fdd29a51cd1fc754b8c523e212c58e1d2544;p=thirdparty%2Fsquid.git

don't assert when closing ntlm connections as the user may be locked for logging purposes
---

diff --git a/src/auth/ntlm/auth_ntlm.cc b/src/auth/ntlm/auth_ntlm.cc
index 8c9aaa4364..92fb216988 100644
--- a/src/auth/ntlm/auth_ntlm.cc
+++ b/src/auth/ntlm/auth_ntlm.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: auth_ntlm.cc,v 1.37 2003/08/10 11:00:52 robertc Exp $
+ * $Id: auth_ntlm.cc,v 1.38 2003/10/15 12:03:08 robertc Exp $
  *
  * DEBUG: section 29    NTLM Authenticator
  * AUTHOR: Robert Collins
@@ -954,13 +954,10 @@ authenticateNTLMOnCloseConnection(ConnStateData * conn)
         /* unlock the connection based lock */
         debug(29, 9) ("authenticateNTLMOnCloseConnection: Unlocking auth_user from the connection.\n");
 
-        /* This still breaks the abstraction, but is at least read only now */
-        /* Ensure that the auth user request will be getting closed */
-        /* IFF we start persisting the struct after the conn closes - say for logging
-         * then this test may become invalid
-         */
-        assert(authenticateRequestRefCount(conn->auth_user_request) == 1);
-
+        /* This still breaks the abstraction, but is at least read only now.
+        * If needed, this could be ignored, as the conn deletion will also unlock
+        * the auth user request.
+        */
         authenticateAuthUserRequestUnlock(conn->auth_user_request);
 
         conn->auth_user_request = NULL;