From: Noel Power <noel.power@suse.com>
Date: Wed, 10 Jul 2019 10:37:34 +0000 (+0000)
Subject: libcli/smb: clang: Fix 'Array access results in a null pointer deref'
X-Git-Tag: talloc-2.3.0~76
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3594c3ae202688fd8aae5f7f5e20464cb23feea9;p=thirdparty%2Fsamba.git

libcli/smb: clang: Fix 'Array access results in a null pointer deref'

Fixes:

smbXcli_base.c:4393:10: warning: Array access (from variable 'inhdr') results in a null pointer dereference <--[clang]
        flags = CVAL(inhdr, HDR_FLG);

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 37ae0a0e0e1..b0e8aabb72e 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -4327,7 +4327,7 @@ static void smbXcli_negprot_smb1_done(struct tevent_req *subreq)
 		struct smbXcli_negprot_state);
 	struct smbXcli_conn *conn = state->conn;
 	struct iovec *recv_iov = NULL;
-	uint8_t *inhdr;
+	uint8_t *inhdr = NULL;
 	uint8_t wct;
 	uint16_t *vwv;
 	uint32_t num_bytes;
@@ -4387,7 +4387,7 @@ static void smbXcli_negprot_smb1_done(struct tevent_req *subreq)
 				  NULL, /* pinbuf */
 				  expected, ARRAY_SIZE(expected));
 	TALLOC_FREE(subreq);
-	if (tevent_req_nterror(req, status)) {
+	if (inhdr == NULL || tevent_req_nterror(req, status)) {
 		return;
 	}