From: Nicki Křížek <nicki@isc.org>
Date: Thu, 9 Jul 2026 09:52:45 +0000 (+0000)
Subject: Drop a redundant racy check in fetchlimit test
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=35bdc768ec019bc575f492bd7817b5f1582925cb;p=thirdparty%2Fbind9.git

Drop a redundant racy check in fetchlimit test

The "lame server recovery" step required the adaptive per-server quota
for the lame server to have dropped further after it started answering
again. That decrease is not reliable: the quota only drops while the
timeout ratio (atr) exceeds the high watermark, and once the server
answers atr falls, so a further drop cannot be relied upon.

Remove the check to improve the fetchlimit test stability in slower
platforms in CI. The quota at the start of the recovery is still
recorded -- it is checked later on that it is increased once the server
recovers.

Assisted-by: Claude:claude-opus-4-8
---

diff --git a/bin/tests/system/fetchlimit/tests.sh b/bin/tests/system/fetchlimit/tests.sh
index 073f932a32e..9ca4b70df73 100644
--- a/bin/tests/system/fetchlimit/tests.sh
+++ b/bin/tests/system/fetchlimit/tests.sh
@@ -145,14 +145,11 @@ status=$((status + ret))
 
 n=$((n + 1))
 echo_i "dumping ADB data ($n)"
-ret=0
 info=$(rndccmd 10.53.0.3 fetchlimit | grep 10.53.0.4 | sed 's/.*quota .*(\([0-9]*\).*atr \([.0-9]*\).*/\2 \1/')
 echo_i $info
 set -- $info
-[ ${2:-${quota}} -lt $quota ] || ret=1
+# Record the quota at start of recovery
 quota=$2
-if [ $ret != 0 ]; then echo_i "failed"; fi
-status=$((status + ret))
 
 n=$((n + 1))
 echo_i "checking lame server recovery (continued) ($n)"