From: Mark Andrews <marka@isc.org>
Date: Mon, 1 Mar 2021 02:58:06 +0000 (+1100)
Subject: Test dynamic libraries should not be installed
X-Git-Tag: v9.17.12~19^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=35e8f56b49976b038ab82b1eb12bd43ba3df9a27;p=thirdparty%2Fbind9.git

Test dynamic libraries should not be installed

Tag the libraries with check_ to prevent them being installed
by "make install".  Additionally make check requires .so to be
create which requires .lai files to be constructed which, in
turn, requires -rpath <dir> as part of "linking" the .la file.
---

diff --git a/bin/tests/system/dlzexternal/driver/Makefile.am b/bin/tests/system/dlzexternal/driver/Makefile.am
index 8d9bc0131eb..a8211d1fb1d 100644
--- a/bin/tests/system/dlzexternal/driver/Makefile.am
+++ b/bin/tests/system/dlzexternal/driver/Makefile.am
@@ -4,11 +4,10 @@ AM_CPPFLAGS +=			\
 	$(LIBISC_CFLAGS)	\
 	$(LIBDNS_CFLAGS)
 
-dlzexternal_LTLIBRARIES = dlzexternal.la
-dlzexternaldir = $(abs_builddir)
+check_LTLIBRARIES = dlzexternal.la
 
 dlzexternal_la_SOURCES =	\
 	driver.c		\
 	driver.h
 
-dlzexternal_la_LDFLAGS = -avoid-version -module -shared -export-dynamic
+dlzexternal_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -rpath $(abs_builddir)
diff --git a/bin/tests/system/dyndb/driver/Makefile.am b/bin/tests/system/dyndb/driver/Makefile.am
index c90510c80ee..f8ceded031c 100644
--- a/bin/tests/system/dyndb/driver/Makefile.am
+++ b/bin/tests/system/dyndb/driver/Makefile.am
@@ -4,8 +4,7 @@ AM_CPPFLAGS +=			\
 	$(LIBISC_CFLAGS)	\
 	$(LIBDNS_CFLAGS)
 
-dyndb_LTLIBRARIES = sample.la
-dyndbdir = $(abs_builddir)
+check_LTLIBRARIES = sample.la
 
 sample_la_SOURCES =	\
 	db.c		\
@@ -23,4 +22,4 @@ sample_la_SOURCES =	\
 	util.h		\
 	zone.h
 
-sample_la_LDFLAGS = -avoid-version -module -shared -export-dynamic
+sample_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -rpath $(abs_builddir)
diff --git a/bin/tests/system/hooks/driver/Makefile.am b/bin/tests/system/hooks/driver/Makefile.am
index 08187bf789f..ffa074a27ce 100644
--- a/bin/tests/system/hooks/driver/Makefile.am
+++ b/bin/tests/system/hooks/driver/Makefile.am
@@ -6,8 +6,7 @@ AM_CPPFLAGS +=			\
 	$(LIBNS_CFLAGS)		\
 	$(LIBISCCFG_CFLAGS)
 
-hooks_LTLIBRARIES = test-async.la
-hooksdir = $(abs_builddir)
+check_LTLIBRARIES = test-async.la
 
 test_async_la_SOURCES = test-async.c
-test_async_la_LDFLAGS = -avoid-version -module -shared -export-dynamic
+test_async_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -rpath $(abs_builddir)