From: Björn Jacke <bjacke@samba.org>
Date: Thu, 19 Apr 2018 14:14:38 +0000 (+0200)
Subject: printing: return the same error code as windows does on upload failures
X-Git-Tag: ldb-1.4.0~534
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=35f2afe411a3b22fb1befadb3bee8da1bc14753c;p=thirdparty%2Fsamba.git

printing: return the same error code as windows does on upload failures

Some print drivers inf files are broken and cause driver installation to fail
on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should
do the same. Windows machines are less unlucky with that.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13395

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Apr 25 13:55:25 CEST 2018 on sn-devel-144
---

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 241af37743e..54357b787f3 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -1217,7 +1217,7 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
 				 "to rename [%s] to [%s]: %s\n",
 				 smb_fname_old->base_name, new_name,
 				 nt_errstr(status)));
-			ret = WERR_ACCESS_DENIED;
+			ret = WERR_APP_INIT_FAILURE;
 			goto out;
 		}
 	}