From: Neal Norwitz <nnorwitz@gmail.com>
Date: Wed, 8 Mar 2006 06:39:50 +0000 (+0000)
Subject: Backport fixes reported by Coverity.
X-Git-Tag: v2.4.3c1~43
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=360641c6e36d5a61e74f805b03b572a7beb41032;p=thirdparty%2FPython%2Fcpython.git

Backport fixes reported by Coverity.
---

diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c
index 438f7609cb22..eb6b22f1e05e 100644
--- a/Modules/pyexpat.c
+++ b/Modules/pyexpat.c
@@ -105,8 +105,8 @@ set_error_attr(PyObject *err, char *name, int value)
 {
     PyObject *v = PyInt_FromLong(value);
 
-    if (v != NULL && PyObject_SetAttrString(err, name, v) == -1) {
-        Py_DECREF(v);
+    if (v == NULL || PyObject_SetAttrString(err, name, v) == -1) {
+        Py_XDECREF(v);
         return 0;
     }
     Py_DECREF(v);
@@ -136,7 +136,7 @@ set_error(xmlparseobject *self, enum XML_Error code)
           && set_error_attr(err, "lineno", lineno)) {
         PyErr_SetObject(ErrorObject, err);
     }
-    Py_DECREF(err);
+    Py_XDECREF(err);
     return NULL;
 }
 
@@ -993,7 +993,7 @@ xmlparse_ParseFile(xmlparseobject *self, PyObject *args)
     if (PyFile_Check(f)) {
         fp = PyFile_AsFile(f);
     }
-    else{
+    else {
         fp = NULL;
         readmethod = PyObject_GetAttrString(f, "read");
         if (readmethod == NULL) {