From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Fri, 13 Mar 2026 19:09:08 +0000 (+0400)
Subject: ui/vnc-jobs: vnc_has_job_locked() argument cannot be NULL
X-Git-Tag: v11.1.0-rc0~161^2~33
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3620f3bab7d615ecab795a5aebbfe2769eae1e40;p=thirdparty%2Fqemu.git

ui/vnc-jobs: vnc_has_job_locked() argument cannot be NULL

The only caller, vnc_jobs_join() cannot take vs == NULL argument, or it
would later crash.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---

diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 4dd7ccad969..8cb30e72276 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -138,7 +138,7 @@ static bool vnc_has_job_locked(VncState *vs)
     VncJob *job;
 
     QTAILQ_FOREACH(job, &queue->jobs, next) {
-        if (job->vs == vs || !vs) {
+        if (job->vs == vs) {
             return true;
         }
     }