From: Andrew Lewis <nerf@judo.za.org>
Date: Fri, 23 Aug 2024 15:04:52 +0000 (+0200)
Subject: [Test] Improve startup error handling
X-Git-Tag: 3.10.0~28^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=366e875b82d1e2ae6b7987b9eaabc5c1afca089c;p=thirdparty%2Frspamd.git

[Test] Improve startup error handling
---

diff --git a/test/functional/lib/rspamd.robot b/test/functional/lib/rspamd.robot
index c45a19908b..559ec667b6 100644
--- a/test/functional/lib/rspamd.robot
+++ b/test/functional/lib/rspamd.robot
@@ -345,7 +345,22 @@ Run Rspamd
   Export Scoped Variables  ${RSPAMD_SCOPE}  RSPAMD_PROCESS=${result}
 
   # Confirm worker is reachable
-  Wait Until Keyword Succeeds  15x  1 sec  Ping Rspamd  ${RSPAMD_LOCAL_ADDR}  ${check_port}
+  FOR    ${index}    IN RANGE    75
+    ${ok} =  Rspamd Startup Check  ${check_port}
+    IF  ${ok}  CONTINUE
+    Sleep  0.1s
+  END
+
+Rspamd Startup Check
+  [Arguments]  ${check_port}=${RSPAMD_PORT_NORMAL}
+  ${res} =  Wait For Process  ${RSPAMD_PROCESS}  0.1s
+  ${handle} =  Get Process Object
+  ${res} =  Evaluate  $handle.poll()
+  IF  ${res} != None
+    Fail  Process Is Gone
+  END
+  ${ping} =  Run Keyword And Return Status  Ping Rspamd  ${RSPAMD_LOCAL_ADDR}  ${check_port}
+  [Return]  ${ping}
 
 Rspamadm Setup
   ${RSPAMADM_TMPDIR} =  Make Temporary Directory