From: Antoine Pitrou <solipsis@pitrou.net>
Date: Wed, 18 Aug 2010 20:44:14 +0000 (+0000)
Subject: Issue #9433: The "-j" option to regrtest now works under Windows too.
X-Git-Tag: v3.2a2~228
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=36e778ef02b74f8a965da1205813e685e3ffcff4;p=thirdparty%2FPython%2Fcpython.git

Issue #9433: The "-j" option to regrtest now works under Windows too.
It is not sure it will be beneficial, though, since process launching is
more expensive under Windows than it is under Linux.
---

diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py
index 9c4584c54c55..308baf462760 100755
--- a/Lib/test/regrtest.py
+++ b/Lib/test/regrtest.py
@@ -547,7 +547,8 @@ def main(tests=None, testdir=None, verbose=0, quiet=False,
                     popen = Popen([sys.executable, '-E', '-m', 'test.regrtest',
                                    '--slaveargs', json.dumps(args_tuple)],
                                    stdout=PIPE, stderr=PIPE,
-                                   universal_newlines=True, close_fds=True)
+                                   universal_newlines=True,
+                                   close_fds=(os.name != 'nt'))
                     stdout, stderr = popen.communicate()
                     # Strip last refcount output line if it exists, since it
                     # comes from the shutdown of the interpreter in the subcommand.