From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Fri, 20 Jan 2023 05:54:44 +0000 (+0900)
Subject: test-unit-name: fix fd leak
X-Git-Tag: v253-rc1~60^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=36f73b6c67afd9c826e612b751ea8f9249da7985;p=thirdparty%2Fsystemd.git

test-unit-name: fix fd leak

Fixes an issue reported at https://github.com/systemd/systemd/issues/22576#issuecomment-1396774385.
---

diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c
index c6428e844f8..3904126a875 100644
--- a/src/test/test-unit-name.c
+++ b/src/test/test-unit-name.c
@@ -242,11 +242,13 @@ TEST_RET(unit_printf, .sd_booted = true) {
                 *user, *group, *uid, *gid, *home, *shell,
                 *tmp_dir, *var_tmp_dir;
         _cleanup_(manager_freep) Manager *m = NULL;
+        _cleanup_close_ int fd = -EBADF;
         Unit *u;
         int r;
 
         _cleanup_(unlink_tempfilep) char filename[] = "/tmp/test-unit_printf.XXXXXX";
-        assert_se(mkostemp_safe(filename) >= 0);
+        fd = mkostemp_safe(filename);
+        assert_se(fd >= 0);
 
         /* Using the specifier functions is admittedly a bit circular, but we don't want to reimplement the
          * logic a second time. We're at least testing that the hookup works. */