From: Patrick H. Lauke Date: Tue, 15 Jan 2013 07:16:33 +0000 (+0000) Subject: Leave tabindex=-1 alone X-Git-Tag: v3.0.0-rc1~697^2~2^2~1 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=370fa45fbe4ee879a626a67bb4df0ec9495102be;p=thirdparty%2Fbootstrap.git Leave tabindex=-1 alone It seems that, as misguided as I personally think it is, ARIA does indeed want dropdown menus not to behave as regular keyboard users expect them, killing TAB/SHIFT+TAB in favor of cursor keys. Fair enough, the issue I have is then with ARIA, not with bootstrap. I would sugges thought that if you really do want to follow ARIA consistently, *any* navigation bar should also become an ARIA menu, further making it impossible for keyboard users to use TAB/SHIFT+TAB to navigate through it, and that these changes should be reflected in the bootstrap examples as well... --- diff --git a/docs/components.html b/docs/components.html index 10ffd2e0c7..3c69c002b5 100644 --- a/docs/components.html +++ b/docs/components.html @@ -118,21 +118,21 @@ 
 <ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu">
-  <li><a tabindex="-1" href="#">Action</a></li>
-  <li><a tabindex="-1" href="#">Another action</a></li>
-  <li><a tabindex="-1" href="#">Something else here</a></li>
+  <li><a href="#">Action</a></li>
+  <li><a href="#">Another action</a></li>
+  <li><a href="#">Something else here</a></li>
   <li class="divider"></li>
-  <li><a tabindex="-1" href="#">Separated link</a></li>
+  <li><a href="#">Separated link</a></li>
 </ul>
@@ -143,11 +143,11 @@ <div class="dropdown"> <!-- Link or button to toggle dropdown --> <ul class="dropdown-menu" role="menu" aria-labelledby="dLabel"> - <li><a tabindex="-1" href="#">Action</a></li> - <li><a tabindex="-1" href="#">Another action</a></li> - <li><a tabindex="-1" href="#">Something else here</a></li> + <li><a href="#">Action</a></li> + <li><a href="#">Another action</a></li> + <li><a href="#">Something else here</a></li> <li class="divider"></li> - <li><a tabindex="-1" href="#">Separated link</a></li> + <li><a href="#">Separated link</a></li> </ul> </div> @@ -171,18 +171,18 @@

Default

@@ -193,18 +193,18 @@

Dropup

@@ -215,18 +215,18 @@

Left submenu

@@ -238,7 +238,7 @@ <ul class="dropdown-menu" role="menu" aria-labelledby="dLabel"> ... <li class="dropdown-submenu"> - <a tabindex="-1" href="#">More options</a> + <a href="#">More options</a> <ul class="dropdown-menu"> ... </ul> diff --git a/docs/javascript.html b/docs/javascript.html index 3e9892843e..131924e0c9 100644 --- a/docs/javascript.html +++ b/docs/javascript.html @@ -405,21 +405,21 @@ $('#myModal').on('hidden', function () {
  • Dropdown
  • Dropdown 2
    • @@ -427,11 +427,11 @@ $('#myModal').on('hidden', function () { @@ -447,31 +447,31 @@ $('#myModal').on('hidden', function () {
  • Dropdown
  • Dropdown 2
  • Dropdown 3