From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 31 Jul 2012 18:35:19 +0000 (-0400)
Subject: test_assert is always in affect: no need for extra gotos
X-Git-Tag: tor-0.2.4.1-alpha~76^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3763959ef0d0510628ec4f54cb3df09f963bc4bd;p=thirdparty%2Ftor.git

test_assert is always in affect: no need for extra gotos
---

diff --git a/src/test/test_introduce.c b/src/test/test_introduce.c
index 72ab55510a..4fbfd18011 100644
--- a/src/test/test_introduce.c
+++ b/src/test/test_introduce.c
@@ -291,10 +291,8 @@ do_parse_test(uint8_t *plaintext, size_t plaintext_len, int phase)
   /* Get a key */
   k = crypto_pk_new();
   test_assert(k);
-  if (!k) goto done;
   r = crypto_pk_read_private_key_from_string(k, AUTHORITY_SIGNKEY_1, -1);
   test_assert(!r);
-  if (r) goto done;
 
   /* Get digest for future comparison */
   r = crypto_pk_get_digest(k, digest);
@@ -306,7 +304,6 @@ do_parse_test(uint8_t *plaintext, size_t plaintext_len, int phase)
       k, (void **)(&cell));
   test_assert(r > 0);
   test_assert(cell);
-  if (!(cell && r > 0)) goto done;
   cell_len = r;
 
   /* Do early parsing */