From: Kumar Aditya <kumaraditya@python.org>
Date: Tue, 12 Nov 2024 12:31:34 +0000 (+0530)
Subject: gh-126405: fix use-after-free in `_asyncio.Future.remove_done_callback` (#126733)
X-Git-Tag: v3.14.0a2~80
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=37c57dfad12744608091653fd753a1f770e2479b;p=thirdparty%2FPython%2Fcpython.git

gh-126405: fix use-after-free in `_asyncio.Future.remove_done_callback` (#126733)
---

diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
index 617a3dca35d9..f883125a2c70 100644
--- a/Modules/_asynciomodule.c
+++ b/Modules/_asynciomodule.c
@@ -1017,8 +1017,10 @@ _asyncio_Future_remove_done_callback_impl(FutureObj *self, PyTypeObject *cls,
 
     if (len == 1) {
         PyObject *cb_tup = PyList_GET_ITEM(self->fut_callbacks, 0);
+        Py_INCREF(cb_tup);
         int cmp = PyObject_RichCompareBool(
             PyTuple_GET_ITEM(cb_tup, 0), fn, Py_EQ);
+        Py_DECREF(cb_tup);
         if (cmp == -1) {
             return NULL;
         }