From: Volker Lendecke <vl@samba.org>
Date: Wed, 27 Nov 2024 11:37:21 +0000 (+0100)
Subject: libcli: Simplify sddl_decode_err_msg()
X-Git-Tag: tdb-1.4.13~420
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=37e7203b0d1409e1d0a3383fbb3baaddd1b3cf43;p=thirdparty%2Fsamba.git

libcli: Simplify sddl_decode_err_msg()

We have security_descriptor_initialise() for this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index c0fddb72e5f..c2a6ca26fc3 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -923,12 +923,10 @@ struct security_descriptor *sddl_decode_err_msg(TALLOC_CTX *mem_ctx, const char
 	*msg = NULL;
 	*msg_offset = 0;
 
-	sd = talloc_zero(mem_ctx, struct security_descriptor);
+	sd = security_descriptor_initialise(mem_ctx);
 	if (sd == NULL) {
 		return NULL;
 	}
-	sd->revision = SECURITY_DESCRIPTOR_REVISION_1;
-	sd->type     = SEC_DESC_SELF_RELATIVE;
 
 	while (*sddl) {
 		uint32_t flags;