From: NeilBrown <neilb@suse.com>
Date: Wed, 5 Aug 2015 04:53:33 +0000 (+1000)
Subject: main: remove use of uninitialized 'rv'.
X-Git-Tag: mdadm-3.4~59
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=380487fdc9773fc93d2cb4f17560a067f87107ac;p=thirdparty%2Fmdadm.git

main: remove use of uninitialized 'rv'.

If c.homecluster was not NULL, might get an
error anyway.

Signed-off-by: NeilBrown <neilb@suse.com>
---

diff --git a/mdadm.c b/mdadm.c
index dcb49d0a..5d5a1b88 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1293,11 +1293,12 @@ int main(int argc, char *argv[])
 		c.require_homehost = 0;
 	}
 
+	rv = 0;
 	if (c.homecluster == NULL && (c.nodes > 0)) {
 		c.homecluster = conf_get_homecluster();
 		if (c.homecluster == NULL)
 			rv = get_cluster_name(&c.homecluster);
-		if (rv != 0) {
+		if (rv) {
 			pr_err("The md can't get cluster name\n");
 			exit(1);
 		}
@@ -1322,7 +1323,6 @@ int main(int argc, char *argv[])
 		/* --scan implied --brief unless -vv */
 		c.brief = 1;
 
-	rv = 0;
 	switch(mode) {
 	case MANAGE:
 		/* readonly, add/remove, readwrite, runstop */