From: Guido van Rossum <guido@python.org>
Date: Fri, 18 Oct 2002 13:52:42 +0000 (+0000)
Subject: Sigh.  That wasn't a memory leak, that was Guido committing before
X-Git-Tag: v2.2.3c1~294
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=38a22a961cfc9a9fa0bf2f7b38c3cbc8a3a2aa30;p=thirdparty%2FPython%2Fcpython.git

Sigh.  That wasn't a memory leak, that was Guido committing before
running tests.  Withdraw 2.183 and its backport.
---

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 2427c4e24ab7..8a1adc914594 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -2249,11 +2249,8 @@ add_subclass(PyTypeObject *base, PyTypeObject *type)
 	while (--i >= 0) {
 		ref = PyList_GET_ITEM(list, i);
 		assert(PyWeakref_CheckRef(ref));
-		if (PyWeakref_GET_OBJECT(ref) == Py_None) {
-			i = PyList_SetItem(list, i, new);
-			Py_DECREF(new);
-			return i;
-		}
+		if (PyWeakref_GET_OBJECT(ref) == Py_None)
+			return PyList_SetItem(list, i, new);
 	}
 	i = PyList_Append(list, new);
 	Py_DECREF(new);