From: Jürg Billeter <j@bitron.ch>
Date: Thu, 15 Oct 2009 19:27:08 +0000 (+0200)
Subject: Warn if signal hides member in base class
X-Git-Tag: 0.7.8~48
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=38f51d81d939dfd98099109ffd75c9000bee513a;p=thirdparty%2Fvala.git

Warn if signal hides member in base class
---

diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index c58e160e1..207d8f737 100644
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -265,6 +265,12 @@ public class Vala.Signal : Member, Lockable {
 			cl.add_hidden_method (default_handler);
 			default_handler.check (analyzer);
 		}
+
+
+		if (!external_package && !hides && get_hidden_member () != null) {
+			Report.warning (source_reference, "%s hides inherited signal `%s'. Use the `new' keyword if hiding was intentional".printf (get_full_name (), get_hidden_member ().get_full_name ()));
+		}
+
 		return !error;
 	}
 }