From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 11 Jul 2018 00:16:37 +0000 (-0400)
Subject: Explain why we use raw_free with getdelim result.
X-Git-Tag: tor-0.3.5.1-alpha~225^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=391ef5e42cc79982a28aaaf22e9f9b255f6910d3;p=thirdparty%2Ftor.git

Explain why we use raw_free with getdelim result.
---

diff --git a/src/feature/dircache/dirserv.c b/src/feature/dircache/dirserv.c
index 57de6ab8ed..1500467ec0 100644
--- a/src/feature/dircache/dirserv.c
+++ b/src/feature/dircache/dirserv.c
@@ -2682,8 +2682,10 @@ dirserv_read_measured_bandwidths(const char *from_file,
   rv = 0;
 
  err:
-  if (line)
+  if (line) {
+    // we need to raw_free this buffer because we got it from tor_getdelim()
     raw_free(line);
+  }
   if (fp)
     fclose(fp);
   return rv;