From: Volker Lendecke Date: Thu, 14 Nov 2024 16:09:31 +0000 (+0100) Subject: libnet: Fix Coverity ID 1634803 Dereference after null check X-Git-Tag: tdb-1.4.13~512 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3987cb0bc357602c1fd3f1263813c5a5289b72c5;p=thirdparty%2Fsamba.git libnet: Fix Coverity ID 1634803 Dereference after null check Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Thu Nov 14 18:29:46 UTC 2024 on atb-devel-224 --- diff --git a/source4/libnet/libnet_site.c b/source4/libnet/libnet_site.c index 369db586fb9..9ee51f3ee86 100644 --- a/source4/libnet/libnet_site.c +++ b/source4/libnet/libnet_site.c @@ -85,7 +85,7 @@ NTSTATUS libnet_FindSite(TALLOC_CTX *ctx, struct libnet_context *lctx, struct li map_netlogon_samlogon_response(resp); - if ((nt5ex->client_site != NULL) || + if ((nt5ex->client_site != NULL) && (nt5ex->client_site[0] != '\0')) { site_name_str = talloc_strdup(tmp_ctx,