From: Sam Gross Date: Fri, 14 Feb 2025 21:21:45 +0000 (-0500) Subject: gh-130095: Mark `_py_abc` tests as not thread-safe (gh-130131) X-Git-Tag: v3.14.0a6~415 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=39cd9728a6770d8fe7937c57385cda5c2e25a223;p=thirdparty%2FPython%2Fcpython.git gh-130095: Mark `_py_abc` tests as not thread-safe (gh-130131) The `_py_abc` implementation is not currently thread-safe (even with the GIL). Don't run these tests with `--parallel-threads=N` for now. --- diff --git a/Lib/test/test_abc.py b/Lib/test/test_abc.py index e90a8dc617c0..80ee9e0ba56e 100644 --- a/Lib/test/test_abc.py +++ b/Lib/test/test_abc.py @@ -684,10 +684,16 @@ def test_factory(abc_ABCMeta, abc_get_cache_token): return TestLegacyAPI, TestABC, TestABCWithInitSubclass -TestLegacyAPI_Py, TestABC_Py, TestABCWithInitSubclass_Py = test_factory(abc.ABCMeta, - abc.get_cache_token) -TestLegacyAPI_C, TestABC_C, TestABCWithInitSubclass_C = test_factory(_py_abc.ABCMeta, - _py_abc.get_cache_token) +TestLegacyAPI_Py, TestABC_Py, TestABCWithInitSubclass_Py = test_factory(_py_abc.ABCMeta, + _py_abc.get_cache_token) +TestLegacyAPI_C, TestABC_C, TestABCWithInitSubclass_C = test_factory(abc.ABCMeta, + abc.get_cache_token) + +# gh-130095: The _py_abc tests are not thread-safe when run with +# `--parallel-threads` +TestLegacyAPI_Py.__unittest_thread_unsafe__ = True +TestABC_Py.__unittest_thread_unsafe__ = True +TestABCWithInitSubclass_Py.__unittest_thread_unsafe__ = True if __name__ == "__main__": unittest.main()