From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Date: Thu, 16 May 2019 19:29:52 +0000 (+0200)
Subject: vfs_gpfs: Fix return value if getting data fails
X-Git-Tag: ldb-2.0.5~765
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3a4f23636d60799a3d3b80d395ef7af710195919;p=thirdparty%2Fsamba.git

vfs_gpfs: Fix return value if getting data fails

Returning -1 in a function with bool as return value type is the same
as returning true. Change to false to indicate the error.

Detected by the help of cppcheck.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index 52c4e5ef25d..a1fe91d0df4 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -1995,7 +1995,7 @@ static bool vfs_gpfs_is_offline(struct vfs_handle_struct *handle,
 
 	SMB_VFS_HANDLE_GET_DATA(handle, config,
 				struct gpfs_config_data,
-				return -1);
+				return false);
 
 	if (!config->winattr) {
 		return false;