From: Volker Lendecke <vl@samba.org>
Date: Mon, 25 Nov 2024 11:04:53 +0000 (+0100)
Subject: libcli: Avoid an unnecessary "else"
X-Git-Tag: tdb-1.4.13~327
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3b2134e231fe74bc51bb3c9550ec4233f58c569f;p=thirdparty%2Fsamba.git

libcli: Avoid an unnecessary "else"

We return in the if-branch

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/libcli/security/security_descriptor.c b/libcli/security/security_descriptor.c
index a7159e7da7e..60e206bf7da 100644
--- a/libcli/security/security_descriptor.c
+++ b/libcli/security/security_descriptor.c
@@ -298,7 +298,8 @@ static NTSTATUS security_descriptor_acl_add(struct security_descriptor *sd,
 
 	if (idx < 0) {
 		return NT_STATUS_ARRAY_BOUNDS_EXCEEDED;
-	} else if (idx > acl->num_aces) {
+	}
+	if (idx > acl->num_aces) {
 		return NT_STATUS_ARRAY_BOUNDS_EXCEEDED;
 	}