From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 9 Jun 2026 18:32:23 +0000 (-0700)
Subject: net: shaper: add a comment why we don't need kfree_rcu() in flush
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3b4ba57263383942a9bea2def3e82750f9a929d8;p=thirdparty%2Fkernel%2Flinux.git

net: shaper: add a comment why we don't need kfree_rcu() in flush

We keep getting misguided patches to fix the flush.
Add a comment.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260609183224.1108521-4-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c
index 33958462e5e99..5a3b44c5d10f6 100644
--- a/net/shaper/shaper.c
+++ b/net/shaper/shaper.c
@@ -1470,6 +1470,10 @@ static void net_shaper_flush(struct net_shaper_binding *binding)
 
 	xa_for_each(&hierarchy->shapers, index, cur) {
 		xa_erase(&hierarchy->shapers, index);
+		/* No need to use kfree_rcu(), netdev is already unpublished,
+		 * and synchronize_rcu() has been run as part of
+		 * unregister_netdevice().
+		 */
 		kfree(cur);
 	}