From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 25 Nov 2019 15:33:53 +0000 (+0100)
Subject: check-symfile: Use pythonesque string formatting instead of perl
X-Git-Tag: v5.10.0-rc1~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3b9359cd44b5a97fe5d670ee33ff13c4bf297ea8;p=thirdparty%2Flibvirt.git

check-symfile: Use pythonesque string formatting instead of perl

Commit d30a1ad0443 translated the symbol file checker from perl to
python by doing a literal translation in most cases. Unfortunately one
string formatting operation was not really translated into python
leaving users with non-helpful error:

'Symbol $1 is listed twice'

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/scripts/check-symfile.py b/scripts/check-symfile.py
index 0c02591991..7aeb047d89 100755
--- a/scripts/check-symfile.py
+++ b/scripts/check-symfile.py
@@ -52,7 +52,7 @@ with open(symfile, "r") as fh:
         line = line.strip(";")
 
         if line in wantsyms:
-            print("Symbol $1 is listed twice", file=sys.stderr)
+            print("Symbol %s is listed twice" % line, file=sys.stderr)
             ret = 1
         else:
             wantsyms[line] = True