From: Andrew Bartlett Date: Tue, 5 Nov 2019 03:15:38 +0000 (+1300) Subject: ndrdump: Fix new "struct" feature X-Git-Tag: talloc-2.3.1~62 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3b9e983b648bd3738d8a5e1d53f29cd21ba63387;p=thirdparty%2Fsamba.git ndrdump: Fix new "struct" feature BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Andrew Bartlett Signed-off-by: Douglas Bagnall Pair-progammed-with: Douglas Bagnall --- diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c index a8f1969a2d4..c18531c9b1e 100644 --- a/librpc/tools/ndrdump.c +++ b/librpc/tools/ndrdump.c @@ -375,7 +375,7 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...) } if (strcmp(type, "struct") == 0) { - flags = 0; /* neither NDR_IN nor NDR_OUT */ + flags = NDR_SCALARS|NDR_BUFFERS; /* neither NDR_IN nor NDR_OUT */ f = find_struct(p, format, &f_buffer); } else { f = find_function(p, format); diff --git a/selftest/knownfail.d/ndrdump b/selftest/knownfail.d/ndrdump deleted file mode 100644 index 6ad82d78eb1..00000000000 --- a/selftest/knownfail.d/ndrdump +++ /dev/null @@ -1,2 +0,0 @@ -^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_with_binary_struct_name -^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_with_hex_struct_name