From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 27 Feb 2023 15:13:33 +0000 (+0100)
Subject: BUG/MINOR: stream: Remove BUG_ON about the task expiration in process_stream()
X-Git-Tag: v2.8-dev5~94
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3bbd2baab3bbbc2234b8e252f5e0cd311e490395;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stream: Remove BUG_ON about the task expiration in process_stream()

At the end of process_stream(), A BUG_ON was recently added to abort if we
leave the function with an expired task. However, it may happen if an event
prevents the timeout to be handled but nothing evolved. In this case, the
task expiration is not updated and we expect to catch the timeout on the
immediate task wakeup.

No backport needed.
---

diff --git a/src/stream.c b/src/stream.c
index 28bb986684..4596fa6aab 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -2533,7 +2533,6 @@ struct task *process_stream(struct task *t, void *context, unsigned int state)
 
 		t->expire = tick_first(t->expire, s->conn_exp);
 
-		BUG_ON(tick_is_expired(t->expire, now_ms));
 
 		s->pending_events &= ~(TASK_WOKEN_TIMER | TASK_WOKEN_RES);
 		stream_release_buffers(s);