From: Volker Lendecke <vl@samba.org>
Date: Wed, 17 Jan 2018 13:45:49 +0000 (+0100)
Subject: winbind: Fix CID 1427626 Uninitialized scalar variable
X-Git-Tag: tevent-0.9.36~304
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3be1e68ce69f7ab8ac2cac97920c0e7f65b5ed6f;p=thirdparty%2Fsamba.git

winbind: Fix CID 1427626 Uninitialized scalar variable

Likely a false positive, but Coverity can't follow all the paths leading
to line 1598.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 17 23:58:34 CET 2018 on sn-devel-144
---

diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index 6e34b5a777d..97425e859f3 100644
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -1428,7 +1428,7 @@ static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
 	int netr_attempts = 0;
 	bool retry = false;
 	NTSTATUS result;
-	uint16_t validation_level;
+	uint16_t validation_level = UINT16_MAX;
 	union netr_Validation *validation = NULL;
 
 	do {