From: Tigran Sogomonian <tsogomonian@astralinux.ru>
Date: Mon, 29 Jun 2026 12:52:06 +0000 (+0300)
Subject: disk-utils: fix memory leak in execute function
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3c053487dddfee89ffc401822971fc7cb95c934d;p=thirdparty%2Futil-linux.git

disk-utils: fix memory leak in execute function

Dynamic memory, referenced by 'argv', is allocated by calling function
'xstrdup' and lost when function returns.

Found by the static analyzer Svace.

Signed-off-by: Tigran Sogomonian <tsogomonian@astralinux.ru>
---

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index cf9c8e420..3f972cff5 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -682,6 +682,8 @@ static int execute(const char *progname, const char *progpath,
 		pid = -1;
 	else if ((pid = fork()) < 0) {
 		warn(_("fork failed"));
+		for (i = 0; i < argc; i++)
+			free(argv[i]);
 		free_instance(inst);
 		return errno;
 	} else if (pid == 0) {