From: Rob van der Linde <rob@catalyst.net.nz>
Date: Thu, 18 Jan 2024 02:37:44 +0000 (+1300)
Subject: netcmd: models: check for None in build_expression instead
X-Git-Tag: tdb-1.4.11~1832
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3c8d449ad3d1285f0f87bcc5b17606f85b001ab4;p=thirdparty%2Fsamba.git

netcmd: models: check for None in build_expression instead

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/domain/models/model.py b/python/samba/netcmd/domain/models/model.py
index 8d68c47075b..2c63392caa8 100644
--- a/python/samba/netcmd/domain/models/model.py
+++ b/python/samba/netcmd/domain/models/model.py
@@ -219,7 +219,7 @@ class Model(metaclass=ModelMeta):
 
         for field_name, value in criteria.items():
             field = cls.fields.get(field_name)
-            if not field:
+            if field is None:
                 raise ValueError(f"Unknown field '{field_name}'")
             expression += f"({field.name}={binary_encode(value)})"