From: Uri Simchoni <uri@samba.org>
Date: Sun, 19 Nov 2017 07:19:03 +0000 (+0000)
Subject: ldb: silence some clang warnings in picky developer mode
X-Git-Tag: talloc-2.1.11~416
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3cca62a2ac17f7ae0571f7ca7976e1a8bb42211b;p=thirdparty%2Fsamba.git

ldb: silence some clang warnings in picky developer mode

Avoid const in casting since it doesn't increase code
safety in this case and causes clang to generate const-qual
warning. Also initialize a pointer to NULL to silence clang
uninitialized variable warning.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index 515a69e6981..e61b5b6a4f4 100644
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -510,10 +510,10 @@ static PyObject *py_ldb_dn_set_extended_component(PyLdbDnObject *self, PyObject
 {
 	char *name;
 	int err;
-	uint8_t *value;
+	uint8_t *value = NULL;
 	Py_ssize_t size = 0;
 
-	if (!PyArg_ParseTuple(args, "sz#", &name, (const char**)&value, &size))
+	if (!PyArg_ParseTuple(args, "sz#", &name, (char **)&value, &size))
 		return NULL;
 
 	if (value == NULL) {