From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Mon, 23 Feb 2026 05:35:59 +0000 (+0530)
Subject: OPP: Move break out of scoped_guard in dev_pm_opp_xlate_required_opp()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3d2398f44a2d48fb1c575a6e0bc6b38f3e689e22;p=thirdparty%2Fkernel%2Flinux.git

OPP: Move break out of scoped_guard in dev_pm_opp_xlate_required_opp()

The commit ff9c512041f2 ("OPP: Use mutex locking guards")
unintentionally made the for loop run longer than required.

scoped_guard() is implemented as a for loop. The break statement now
breaks out out the scoped_guard() and not out of the outer for loop.
The outer loop always iterates to completion.

Fix it.

Fixes: ff9c512041f2 ("OPP: Use mutex locking guards")
Reported-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---

diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 866641666e410..da3f5eba43419 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -2742,8 +2742,8 @@ struct dev_pm_opp *dev_pm_opp_xlate_required_opp(struct opp_table *src_table,
 					break;
 				}
 			}
-			break;
 		}
+		break;
 	}
 
 	if (IS_ERR(dest_opp)) {