From: Christof Schmitt <cs@samba.org>
Date: Fri, 12 Apr 2024 22:22:06 +0000 (-0700)
Subject: tdb: Return failure as exit status from test_tdbbackup.sh
X-Git-Tag: tdb-1.4.11~1105
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3d290e31523b5d6c6b6c05cbda2e42983b3bdbb0;p=thirdparty%2Fsamba.git

tdb: Return failure as exit status from test_tdbbackup.sh

When this test is called from wscript, only the exit code is checked.
Track failures and return as non-zero exit code.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/tdb/test/test_tdbbackup.sh b/lib/tdb/test/test_tdbbackup.sh
index 8552ea1029b..7bc025ca42b 100755
--- a/lib/tdb/test/test_tdbbackup.sh
+++ b/lib/tdb/test/test_tdbbackup.sh
@@ -8,6 +8,7 @@ if [ $# -lt 1 ]; then
 fi
 
 LDBFILE=$1
+failed=0
 
 timestamp()
 {
@@ -42,16 +43,22 @@ testit()
 
 $BINDIR/tdbdump $LDBFILE | sort >orig_dump
 
-testit "normal tdbbackup on tdb file" $BINDIR/tdbbackup $LDBFILE -s .bak
+testit "normal tdbbackup on tdb file" $BINDIR/tdbbackup $LDBFILE -s .bak  \
+	|| failed=$((failed + 1))
 $BINDIR/tdbdump $LDBFILE.bak | sort >bak_dump
-testit "cmp between tdbdumps of original and backup" cmp orig_dump bak_dump
+testit "cmp between tdbdumps of original and backup" cmp orig_dump bak_dump \
+	|| failed=$((failed + 1))
 rm $LDBFILE.bak
 rm bak_dump
 
-testit "readonly tdbbackup on tdb file" $BINDIR/tdbbackup $LDBFILE -s .bak -r
+testit "readonly tdbbackup on tdb file" $BINDIR/tdbbackup $LDBFILE -s .bak -r \
+	|| failed=$((failed + 1))
 $BINDIR/tdbdump $LDBFILE.bak | sort >bak_dump
-testit "cmp between tdbdumps of original and back dbs" cmp orig_dump bak_dump
+testit "cmp between tdbdumps of original and back dbs" cmp orig_dump bak_dump \
+	|| failed=$((failed + 1))
 rm $LDBFILE.bak
 rm bak_dump
 
 rm orig_dump
+
+exit $failed