From: Wei Yongjun Date: Wed, 9 Nov 2022 15:01:16 +0000 (+0000) Subject: eth: sp7021: drop free_netdev() from spl2sw_init_netdev() X-Git-Tag: v6.0.9~78 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3d9490def95ba1ec457c7fa1a5f2cb5cfaa929cd;p=thirdparty%2Fkernel%2Fstable.git eth: sp7021: drop free_netdev() from spl2sw_init_netdev() [ Upstream commit de91b3197d15172407608b2c357aab7ac1451e2b ] It's not necessary to free netdev allocated with devm_alloc_etherdev() and using free_netdev() leads to double free. Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021") Signed-off-by: Wei Yongjun Link: https://lore.kernel.org/r/20221109150116.2988194-1-weiyongjun@huaweicloud.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c index 61d1d07dc0704..d6f1fef4ff3af 100644 --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c @@ -286,7 +286,6 @@ static u32 spl2sw_init_netdev(struct platform_device *pdev, u8 *mac_addr, if (ret) { dev_err(&pdev->dev, "Failed to register net device \"%s\"!\n", ndev->name); - free_netdev(ndev); *r_ndev = NULL; return ret; }