From: Chao Yu Date: Wed, 19 Jul 2023 13:50:46 +0000 (+0800) Subject: f2fs: remove unneeded check condition in __f2fs_setxattr() X-Git-Tag: v5.10.227~330 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3dc483f0e6d09e19fa7d8d6810cab124e7fd756f;p=thirdparty%2Fkernel%2Fstable.git f2fs: remove unneeded check condition in __f2fs_setxattr() [ Upstream commit bc3994ffa4cf23f55171943c713366132c3ff45d ] It has checked return value of write_all_xattrs(), remove unneeded following check condition. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Stable-dep-of: aaf8c0b9ae04 ("f2fs: reduce expensive checkpoint trigger frequency") Signed-off-by: Sasha Levin --- diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index a3a11678d414d..c92ddc8c33a14 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -756,7 +756,7 @@ static int __f2fs_setxattr(struct inode *inode, int index, if (index == F2FS_XATTR_INDEX_ENCRYPTION && !strcmp(name, F2FS_XATTR_NAME_ENCRYPTION_CONTEXT)) f2fs_set_encrypted_inode(inode); - if (!error && S_ISDIR(inode->i_mode)) + if (S_ISDIR(inode->i_mode)) set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP); same: