From: Joe Thornber Date: Mon, 26 Jan 2015 11:38:21 +0000 (+0000) Subject: dm thin: don't allow messages to be sent to a pool target in READ_ONLY or FAIL mode X-Git-Tag: v3.16.35~2910 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3deb5859ee2211b73be48bf444cde991a6133045;p=thirdparty%2Fkernel%2Fstable.git dm thin: don't allow messages to be sent to a pool target in READ_ONLY or FAIL mode commit 2a7eaea02b99b6e267b1e89c79acc6e9a51cee3b upstream. You can't modify the metadata in these modes. It's better to fail these messages immediately than let the block-manager deny write locks on metadata blocks. Otherwise these failed metadata changes will trigger 'needs_check' to get set in the metadata superblock -- requiring repair using the thin_check utility. Signed-off-by: Joe Thornber Signed-off-by: Mike Snitzer Signed-off-by: Luis Henriques --- diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 408ffba7ec634..add44f5a87b14 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -2913,6 +2913,12 @@ static int pool_message(struct dm_target *ti, unsigned argc, char **argv) struct pool_c *pt = ti->private; struct pool *pool = pt->pool; + if (get_pool_mode(pool) >= PM_READ_ONLY) { + DMERR("%s: unable to service pool target messages in READ_ONLY or FAIL mode", + dm_device_name(pool->pool_md)); + return -EINVAL; + } + if (!strcasecmp(argv[0], "create_thin")) r = process_create_thin_mesg(argc, argv, pool);