From: Ralph Boehme <slow@samba.org>
Date: Thu, 15 Oct 2020 17:48:42 +0000 (+0200)
Subject: smbd: fix order of smb_fname flags and twrp args in unlink_internals()
X-Git-Tag: talloc-2.3.2~149
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3df5f851c67fcbac01a214ede9bffd3e20231de3;p=thirdparty%2Fsamba.git

smbd: fix order of smb_fname flags and twrp args in unlink_internals()

As snapshots are read-only by design, this bug was likely not a real issue so
I'm not creating a BUG for this.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 51f95f565c0..2c15366172d 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -3446,8 +3446,8 @@ NTSTATUS unlink_internals(connection_struct *conn,
 						p,
 						NULL,
 						&smb_fname->st,
-						smb_fname->flags,
-						smb_fname->twrp);
+						smb_fname->twrp,
+						smb_fname->flags);
 			if (f == NULL) {
 				TALLOC_FREE(dir_hnd);
 				status = NT_STATUS_NO_MEMORY;