From: Mark Michelson <mmichelson@digium.com>
Date: Fri, 13 Feb 2009 19:47:48 +0000 (+0000)
Subject: Fix a potential crash situation when using IMAP voicemail
X-Git-Tag: 1.4.24-rc1~61
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3e0b36d9d09b6f14fa9f7e38e7f25d49409749a3;p=thirdparty%2Fasterisk.git

Fix a potential crash situation when using IMAP voicemail

If calling into VoiceMailMain when using IMAP storage, it was
possible to crash Asterisk by hanging up the phone when prompted
for a voicemail mailbox. This patch fixes the issue.

While it may appear that this patch is superficial, it allows code
execution to continue to the failure case just below the IMAP_STORAGE
code block where this patch has been applied

(closes issue #14473)
Reported by: dwpaul
Patches:
      voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@175590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 6a4677aa96..3566e71f40 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -7326,7 +7326,8 @@ static int vm_execmain(struct ast_channel *chan, void *data)
 #ifdef IMAP_STORAGE
 	vms.interactive = 1;
 	vms.updated = 1;
-	ast_copy_string(vms.context, vmu->context, sizeof(vms.context));
+	if (vmu)
+		ast_copy_string(vms.context, vmu->context, sizeof(vms.context));
 	vmstate_insert(&vms);
 	init_vm_state(&vms);
 #endif