From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 27 Jan 2017 13:28:31 +0000 (+1300)
Subject: Complain about malformed 64bit header values, not the valid ones.
X-Git-Tag: SQUID_4_0_18~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3e1e155b351e73f7369c895eec9e96365b4a0713;p=thirdparty%2Fsquid.git

Complain about malformed 64bit header values, not the valid ones.

Added this regression in r14819, apparently confused by my own
unfortunate "bad is true" httpHeaderNoteParsedEntry(error) API.
---

diff --git a/src/HttpHeader.cc b/src/HttpHeader.cc
index 2acc70228f..1733ab6490 100644
--- a/src/HttpHeader.cc
+++ b/src/HttpHeader.cc
@@ -1467,7 +1467,7 @@ HttpHeaderEntry::getInt64() const
 {
     int64_t val = -1;
     const bool ok = httpHeaderParseOffset(value.termedBuf(), &val);
-    httpHeaderNoteParsedEntry(id, value, ok);
+    httpHeaderNoteParsedEntry(id, value, !ok);
     return val; // remains -1 if !ok (XXX: bad method API)
 }