From: Andrew Bartlett <abartlet@samba.org>
Date: Wed, 5 Aug 2009 00:35:45 +0000 (+1000)
Subject: s4:ldb initialise e->values[i].length before use in python bindings
X-Git-Tag: talloc-2.0.0~474
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3e3f64f05fa5d970b058c4b21b6ecd40b883e8e6;p=thirdparty%2Fsamba.git

s4:ldb initialise e->values[i].length before use in python bindings
---

diff --git a/source4/lib/ldb/pyldb.c b/source4/lib/ldb/pyldb.c
index a05aab5b839..8a061c7e8ec 100644
--- a/source4/lib/ldb/pyldb.c
+++ b/source4/lib/ldb/pyldb.c
@@ -1544,9 +1544,9 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
 			el->values = talloc_array(el, struct ldb_val, el->num_values);
 			for (i = 0; i < el->num_values; i++) {
 				PyObject *item = PySequence_GetItem(py_elements, i);
+				el->values[i].length = PyString_Size(item);
 				el->values[i].data = talloc_memdup(el, 
 					(uint8_t *)PyString_AsString(item), el->values[i].length);
-				el->values[i].length = PyString_Size(item);
 			}
 		} else {
 			PyErr_SetString(PyExc_TypeError,