From: Roger Dingledine <arma@torproject.org>
Date: Thu, 8 Apr 2004 03:18:03 +0000 (+0000)
Subject: bugfix: alice would crash if bob advertised 0 intro points
X-Git-Tag: tor-0.0.6incompat-merged~85
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3e7c8a40bca3ed5eda71e237ee79149a9d058e36;p=thirdparty%2Ftor.git

bugfix: alice would crash if bob advertised 0 intro points


svn:r1559
---

diff --git a/src/or/rendclient.c b/src/or/rendclient.c
index 540fa2b3f8..aa32ead26f 100644
--- a/src/or/rendclient.c
+++ b/src/or/rendclient.c
@@ -284,6 +284,10 @@ char *rend_client_get_random_intro(char *query) {
     smartlist_add(sl,entry->parsed->intro_points[i]);
 
   choice = smartlist_choose(sl);
+  if(!choice) {
+    smartlist_free(sl);
+    return NULL;
+  }
   nickname = tor_strdup(choice);
   smartlist_free(sl);
   return nickname;