From: Jay Satiro <raysatiro@yahoo.com>
Date: Tue, 22 Nov 2016 21:10:06 +0000 (-0500)
Subject: url: Fix conn reuse for local ports and interfaces
X-Git-Tag: curl-7_52_0~101
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3e9c0230f45cafb9154bb4fcdc8ff2b51f00701a;p=thirdparty%2Fcurl.git

url: Fix conn reuse for local ports and interfaces

- Fix connection reuse for when the proposed new conn 'needle' has a
specified local port but does not have a specified device interface.

Bug: https://curl.haxx.se/mail/lib-2016-11/0137.html
Reported-by: bjt3[at]hotmail.com
---

diff --git a/lib/url.c b/lib/url.c
index 7106d46d41..552be94687 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -3400,9 +3400,8 @@ ConnectionExists(struct Curl_easy *data,
         */
         if((check->localport != needle->localport) ||
            (check->localportrange != needle->localportrange) ||
-           !check->localdev ||
-           !needle->localdev ||
-           strcmp(check->localdev, needle->localdev))
+           (needle->localdev &&
+            (!check->localdev || strcmp(check->localdev, needle->localdev))))
           continue;
       }