From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 5 Jan 2016 19:26:35 +0000 (+0100)
Subject: resolved: fix DNSSEC transaction dependency recursion check
X-Git-Tag: v229~161^2~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3eb6aa009dd0b64dc2b326acaa38821462b8c6bf;p=thirdparty%2Fsystemd.git

resolved: fix DNSSEC transaction dependency recursion check

We followed the wrong connection. This only worked sometimes at all, because we
also return the wrong error code.
---

diff --git a/src/resolve/resolved-dns-transaction.c b/src/resolve/resolved-dns-transaction.c
index 44267c6b2dd..7cf299bac80 100644
--- a/src/resolve/resolved-dns-transaction.c
+++ b/src/resolve/resolved-dns-transaction.c
@@ -1284,13 +1284,13 @@ static int dns_transaction_find_cyclic(DnsTransaction *t, DnsTransaction *aux) {
         if (t == aux)
                 return 1;
 
-        SET_FOREACH(n, aux->notify_transactions, i) {
+        SET_FOREACH(n, aux->dnssec_transactions, i) {
                 r = dns_transaction_find_cyclic(t, n);
                 if (r != 0)
                         return r;
         }
 
-        return r;
+        return 0;
 }
 
 static int dns_transaction_add_dnssec_transaction(DnsTransaction *t, DnsResourceKey *key, DnsTransaction **ret) {